Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add enter handler for the textbox #407

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add enter handler for the textbox #407

wants to merge 4 commits into from

Conversation

VijithaEkanayake-zz
Copy link

Fixes: #372

mturoci
mturoci requested changes Dec 18, 2020
View reviewed changes
Copy link
Collaborator

@mturoci mturoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @VijithaEkanayake! A few comments from me.

py/examples/textbox.py Outdated
Comment on lines 25 to 29
elif q.args.enter_key_handler:
q.page['example'].items = [
ui.text(f'textbox_enter_key_handler={q.args.enter_key_handler}'),
ui.button(name='show_form', label='Back', primary=True),
]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess a better scenario would be to show every input filled (add the enter handler logic to q.args.show if branch instead), not just enter handler as the enter submits the whole form, not just a single item and might cause confusion for some people. @lo5 wdyt.

py/examples/textbox.py Outdated
@@ -36,6 +41,7 @@ async def serve(q: Q):
ui.textbox(name='textbox_placeholder', label='With placeholder', placeholder='I need some input'),
ui.textbox(name='textbox_disabled_placeholder', label='Disabled with placeholder', disabled=True,
placeholder='I am disabled'),
ui.textbox(name='enter_key_handler', label='Submits the textbox value on Enter key', icon='Search'),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go with convention format: textbox_*** so textbox_enter or something for your case.

ui/src/textbox.test.tsx Outdated Show resolved Hide resolved
ui/src/textbox.test.tsx Outdated Show resolved Hide resolved
ui/src/textbox.test.tsx Outdated Show resolved Hide resolved
ui/src/textbox.tsx Outdated Show resolved Hide resolved
ui/src/textbox.tsx Outdated Show resolved Hide resolved
lo5
lo5 requested changes Dec 18, 2020
View reviewed changes
Copy link
Member

@lo5 lo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation unconditionally calls the keyup handler. We need a properly-named attribute on the textbox that conditionally enables this behavior.

@mturoci - this might conflict with #348?

@mturoci
Copy link
Collaborator

mturoci commented Dec 18, 2020

@mturoci - this might conflict with #348?

Yes, I suppose. I suggest addressing both issues in this PR.

VijithaEkanayake and others added 3 commits December 18, 2020 16:45
@VijithaEkanayake @mturoci
Update ui/src/textbox.test.tsx
0b50eb3 
Co-authored-by: mturoci <[email protected]>
@VijithaEkanayake @mturoci
Apply suggestions from code review
6737d9f 
Co-authored-by: mturoci <[email protected]>
@VijithaEkanayake
Introduce submit attribute to textbox
54ea7d5 
The implementation conditionally calls the keyup handler based on the values of the submit attribute.
Fixes: #372
@VijithaEkanayake-zz
Copy link
Author

VijithaEkanayake-zz commented Dec 18, 2020 •
edited
Loading

The implementation unconditionally calls the keyup handler. We need a properly-named attribute on the textbox that conditionally enables this behavior.

@mturoci - this might conflict with #348?

@lo5 @mturoci Introduced a new attribute called submit to the textbox to conditionally call the keyUp handler and addressed the requested changes.

@lo5 lo5 mentioned this pull request Apr 13, 2021
Open
@lo5 lo5 added this to the 2021 milestone Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mturoci mturoci mturoci requested changes

@lo5 lo5 lo5 requested changes

@dulajra dulajra Awaiting requested review from dulajra

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2021
Development

Successfully merging this pull request may close these issues.

Add enter handler for textbox
4 participants
@VijithaEkanayake-zz @mturoci @lo5 @VijithaEkanayake